Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC-Breaking] Fix model downloading in bento #3803

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

nateanl
Copy link
Member

@nateanl nateanl commented Jun 26, 2024

This is a BC-Breaking change (dl_kwargs removed).

Summary: The model checkpoint path can not be created for Squim models. Use the latest download_asset method to fix it.

Differential Revision: D59061348

@nateanl nateanl requested a review from a team as a code owner June 26, 2024 15:39
Copy link

pytorch-bot bot commented Jun 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3803

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 16774fb with merge base 7f6209b (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59061348

Copy link
Collaborator

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description that this is BC-breaking change (dl_kwargs removed), so that it information can be found easily when crafting the release note?

@nateanl nateanl changed the title Fix model downloading in bento [BC-Breaking] Fix model downloading in bento Jun 26, 2024
@nateanl nateanl enabled auto-merge (squash) June 26, 2024 17:44
nateanl added a commit to nateanl/audio that referenced this pull request Jul 1, 2024
Summary:
Pull Request resolved: pytorch#3803

The model checkpoint path can not be created for Squim models. Use the latest download_asset method to fix it.

Reviewed By: moto-meta

Differential Revision: D59061348
@nateanl nateanl force-pushed the export-D59061348 branch from 9161ad0 to 0875dce Compare July 1, 2024 15:00
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59061348

@nateanl nateanl disabled auto-merge July 1, 2024 20:03
@nateanl nateanl enabled auto-merge (squash) July 1, 2024 20:04
Summary:
Pull Request resolved: pytorch#3803

The model checkpoint path can not be created for Squim models. Use the latest download_asset method to fix it.

Reviewed By: moto-meta

Differential Revision: D59061348
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59061348

@nateanl nateanl force-pushed the export-D59061348 branch from 0875dce to 16774fb Compare July 2, 2024 20:07
@nateanl nateanl disabled auto-merge July 3, 2024 20:15
@facebook-github-bot
Copy link
Contributor

@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@nateanl nateanl merged commit 69b2a0a into pytorch:main Jul 3, 2024
65 of 70 checks passed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59061348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants